Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reference ID error with push SF activities for point changes and other timeline events #5446

Merged

Conversation

alanhartless
Copy link
Contributor

@alanhartless alanhartless commented Dec 13, 2017

Q A
Bug fix? y
New feature?
Automated tests included? y
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Some of the time line events did not have an eventId assigned by the subscriber which was used by the SF activity sync to generate a reference ID. If this was not set, the SF activity sync would generate a reference id of -SOMESTRING which triggered the error provided reference ID must start with an alphanumeric character and can not contain a period. This PR fixes that by fixing the few timeline events that were missing an eventId but also generates one if the subscriber forgets to generate one.

Steps to reproduce the bug:

  1. Setup SF Activity syncing
  2. Ensure that a Mautic contact is being tracked against a SF lead or contact
  3. Create a form with a point change submit action
  4. Submit the form with the email of the contact in step 2
  5. Run the m:i:pushactivity command and not the reference ID error

Steps to test this PR:

  1. Repeat and activity will be synced

@alanhartless alanhartless added bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test labels Dec 13, 2017
@alanhartless alanhartless added this to the 2.12.1 milestone Dec 13, 2017
@javjim
Copy link

javjim commented Dec 18, 2017

Working properly,
Guide to setup SF https://mautic.com/help/salesforce-integration-setup/

@javjim javjim added pending-test-confirmation PR's that require one test before they can be merged and removed ready-to-test PR's that are ready to test labels Dec 18, 2017
@javjim javjim assigned javjim and unassigned javjim Dec 19, 2017
@escopecz escopecz self-assigned this Dec 22, 2017
@alanhartless alanhartless merged commit 2cb76a4 into mautic:staging Dec 22, 2017
@alanhartless alanhartless deleted the bug-salesforce-activity-sync branch January 5, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants