Prevent reference ID error with push SF activities for point changes and other timeline events #5446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some of the time line events did not have an eventId assigned by the subscriber which was used by the SF activity sync to generate a reference ID. If this was not set, the SF activity sync would generate a reference id of
-SOMESTRING
which triggered the errorprovided reference ID must start with an alphanumeric character and can not contain a period
. This PR fixes that by fixing the few timeline events that were missing an eventId but also generates one if the subscriber forgets to generate one.Steps to reproduce the bug:
m:i:pushactivity
command and not the reference ID errorSteps to test this PR: