-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrations Bundle - add support to pass custom options to OrderDAO #9796
Merged
RCheesley
merged 4 commits into
mautic:features
from
kuzmany:integrationsbundle-add-to-pass-custom-options
Mar 29, 2021
Merged
Integrations Bundle - add support to pass custom options to OrderDAO #9796
RCheesley
merged 4 commits into
mautic:features
from
kuzmany:integrationsbundle-add-to-pass-custom-options
Mar 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzmany
added
WIP
PR's that are not ready for review and are currently in progress
enhancement
Any improvement to an existing feature or functionality
labels
Mar 17, 2021
cla-bot
bot
added
the
cla-signed
The PR contributors have signed the contributors agreement
label
Mar 17, 2021
Codecov Report
@@ Coverage Diff @@
## features #9796 +/- ##
==============================================
+ Coverage 39.64% 39.65% +0.01%
- Complexity 33978 33985 +7
==============================================
Files 1989 1989
Lines 105730 105751 +21
==============================================
+ Hits 41913 41932 +19
- Misses 63817 63819 +2
|
kuzmany
added
ready-to-test
PR's that are ready to test
and removed
WIP
PR's that are not ready for review and are currently in progress
labels
Mar 19, 2021
dennisameling
previously approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested as follows:
- Clone HelloWorldBundle since it implements the
mautic.sync_integration
(there's no built-in plugin that does it) - ran into a bug with Mautic 4 there, so fixed it while at it 😂 Fix mock handler on Mautic 4 plugin-helloworld#5 - Ran
bin/console mautic:integrations:sync helloworld --disable-pull --option="chanelId:1" --option="typeId:1"
, theoption
array is coming up correctly:
- Tested the same command without
--option
, also works without errors.
Thanks! We do need some developer docs for this I think. Will create a separate issue for that.
dennisameling
added
needs-documentation
PR's that need documentation before they can be merged
ready-to-commit
PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
and removed
ready-to-test
PR's that are ready to test
labels
Mar 26, 2021
dennisameling
removed
the
needs-documentation
PR's that need documentation before they can be merged
label
Mar 26, 2021
dennisameling
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
The PR contributors have signed the contributors agreement
enhancement
Any improvement to an existing feature or functionality
ready-to-commit
PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
T3
Hard difficulty to fix (issue) or test (PR)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In some cases we need pass custom values to synchronization.
This PR introduce options
Usage by code::
Usage by command
mautic:integrations:sync IntegrationName --disable-pull --option="chanelId:1" --option="typeId:1"
Steps to test this PR:
Or provide the code review