Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEXADECAROTOR #1864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Jul 9, 2022

Add 16 rotor definition for OCTA-X16 COPTER.
18 rotor to be added for VOLOCOPTER.

ArduPilot/ardupilot#21154

HexadecaOcta ( OCTA-X16) Copter
Screenshot from 2022-07-14 06-05-45

VOLOCOPTER:
Screenshot from 2022-07-11 07-03-03

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 13, 2022

This looks pretty cool. So:

  • MAV_TYPE_HEXADECAROTOR = 16 rotor
  • MAV_TYPE_OCTADECAROTOR - 18 rotor

@rmackay9 @MaEtUgR @meee1 @DonLakeFlyer I am inclined to accept this - any objections?

My assumption is that most GCS don't really need anything more than the number of rotors? In PX4 at least you'd get more detailed geometry information from the component information file.

The reason I ask is that the Octa in the image is coaxial, so you might want to/need to identify it using MAV_TYPE_OCTADECA_COAX_ROTOR.
I have no idea what you'd call the MAV_TYPE_HEXADECAROTOR layout in that image!

@muramura
Copy link
Contributor Author

muramura commented Jul 13, 2022

I have no idea what you'd call the MAV_TYPE_HEXADECAROTOR layout in that image!

Ex HEXADECAROTOR layout
Screenshot from 2022-07-14 06-05-45

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jul 21, 2022

Discussed in the dev call. How can this work when neither ArduPilot or PX4 currently support more than 16 outputs? We're not opposed to the names, but if this is not going to make its way into something useful for a GCS to configure itself on, not much point adding at this time.

@rmackay9
Copy link
Contributor

The latest versions of AP do support up to 32 outputs but we don't have support for this vehicle type in AP yet.

@hamishwillee
Copy link
Collaborator

Thanks @rmackay9 I guess it is chicken and egg - you'll need this before it goes in. Any particular ETA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants