Winch extended support #1899
Merged
Winch extended support #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dakejahl
commented
Oct 4, 2022
dakejahl
commented
- Extended status (state) flags
- Extended actions to support Eject Package and Load Package
- Added Component ID for Winch
hamishwillee
reviewed
Oct 5, 2022
hamishwillee
reviewed
Oct 5, 2022
hamishwillee
reviewed
Oct 5, 2022
…tus flags for LOCKING, LOAD_LINE, and LOAD_PAYLOAD.
dakejahl
force-pushed
the
pr-winch_status_flags
branch
from
e67497a
to
a8fdb96
Compare
hamishwillee
reviewed
Nov 2, 2022
| @@ -614,6 +614,9 @@ | |||
| <entry value="8" name="WINCH_ABANDON_LINE"> | |||
| <description>Spool out the entire length of the line. Only action and instance command parameters are used, others are ignored.</description> | |||
| </entry> | |||
| <entry value="9" name="WINCH_LOAD_PAYLOAD"> | |||
| <description>Spools out just enough to present the hook to the user to load the payload. Only action and instance command parameters are used, others are ignored</description> | |||
There was a problem hiding this comment.
I think this is good. If we end up adding mechanised hooks we might also add text that indicates this also makes the hook "open".
hamishwillee
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
@julianoes @auturgy I am approving this as the controversial bits are now removed - i.e. the stuff about grippers.
Essentially this now just adds a command to spool out a little line to load a payload, and some additional states. None of this has to be implemented by anyone.
I will merge in a few days if there is no response about approval.
julianoes
approved these changes
Nov 2, 2022
|
Merging. This is non harmful for existing implementations. Thanks for your patience @dakejahl |
TSC21
pushed a commit
to Auterion/mavlink
that referenced
this pull request
Nov 9, 2022
…tus flags for LOCKING, LOAD_LINE, and LOAD_PAYLOAD. (mavlink#1899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.