-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: Add C++11 headers to c_library_v2 #714
base: master
Are you sure you want to change the base?
Conversation
@vooon Could you rebase and is this still up to date? |
@LorenzMeier rebased. Yes, it still should work. |
@vooon still relevant, right? Can you rebase? @LorenzMeier should we bring this in? |
What about having a different repo for C++? Is that something that has been considered? |
I assume that adding C++11 header to c_library_v2 will not break a C build? FWIW C and C++ are quite different and it makes sense to let these evolve differently. I'd be tempted to generate separate cpp_library_v2 repo for now. In future it might make sense to separate generator core and language specific bindings, in which case cpp would also have its own binding repo. |
I agree but we need to give it a better name, e.g. |
C++ is not standalone, it uses same C utils, e.g. parser. |
Yes, we know that. The questions are whether it should be allowed to evolve separately, and whether including those headers causes problems for people developing in C. |
|
All true, but it is possible to write much better code using designed C++ APIs. This is not my call and it isn't a decision that needs to be made now. |
Can this one be discussed at the dev meeting ? |
@amilcarlucas I added the dev call label. Note however that we rarely get through more than a couple of issues, so it actually being looked at depends on having a sponsor. Specifically, someone there who cared about it and can argue the case for or against. |
Would it make sense to add a 2nd repo just for C++? I presume you're not using C and C++ in the same project? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
With that change c_library_v2 will also provide C++11 headers.
C++ generator also call C gen, so all what need to be changed is
--lang
.