Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building SDK from Carthage #120

Closed
douglaswsilva opened this issue May 6, 2019 · 5 comments · Fixed by #123
Closed

Error building SDK from Carthage #120

douglaswsilva opened this issue May 6, 2019 · 5 comments · Fixed by #123
Labels
bug Something isn't working

Comments

@douglaswsilva
Copy link
Collaborator

douglaswsilva commented May 6, 2019

Keep get this error when trying to run carthage bootstrap --platform ios:

3DR-000328:Downloads douglas$ cd /Users/douglas/Downloads/DronecodeSDK-Swift-master\ 2 
3DR-000328:DronecodeSDK-Swift-master 2 douglas$ carthage bootstrap --platform ios
*** Checking out grpc-swift at "0.8.1"
*** Checking out RxSwift at "4.5.0"
*** Downloading binary-only framework backend at "https://s3.eu-central-1.amazonaws.com/dronecode-sdk/backend.json"
*** xcodebuild output can be found in /var/folders/2d/t05mnyvs1ll3z81lgn1xlqgw0000gp/T/carthage-xcodebuild.nGAape.log
*** Downloading RxSwift.framework binary at "[4,5]"
***  Skipped installing RxSwift.framework binary due to the error:
	"Incompatible Swift version - framework was built with 5.0 (swiftlang-1001.0.69.5 clang-1001.0.46.3) and the local version is 4.2.1 (swiftlang-1000.11.42 clang-1000.11.45.1)."

    Falling back to building from the source
*** Building scheme "SwiftGRPC-Package" in SwiftGRPC-Carthage.xcodeproj
Build Failed
	Task failed with exit code 65:
	/usr/bin/xcrun xcodebuild -project /Users/douglas/Downloads/DronecodeSDK-Swift-master\ 2/Carthage/Checkouts/grpc-swift/SwiftGRPC-Carthage.xcodeproj -scheme SwiftGRPC-Package -configuration Release -derivedDataPath /Users/douglas/Library/Caches/org.carthage.CarthageKit/DerivedData/10.1_10B61/grpc-swift/0.8.1 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/2d/t05mnyvs1ll3z81lgn1xlqgw0000gp/T/grpc-swift SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/douglas/Downloads/DronecodeSDK-Swift-master 2/Carthage/Checkouts/grpc-swift)

This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/2d/t05mnyvs1ll3z81lgn1xlqgw0000gp/T/carthage-xcodebuild.nGAape.log
3DR-000328:DronecodeSDK-Swift-master 2 douglas$ 

NOTE: We're using XCode 10.1

@douglaswsilva douglaswsilva added the bug Something isn't working label May 6, 2019
@douglaswsilva
Copy link
Collaborator Author

douglaswsilva commented May 6, 2019

Carthage Logs

@JonasVautherin
Copy link
Collaborator

Seems like they released gRPC-Swift 0.9.0 with "fixes for Swift 5".

@douglaswsilva: would you mind trying gRPC-Swift 0.9.0? Should be a matter of editing the SDK Cartfile and running Carthage again.

@byuarus
Copy link
Collaborator

byuarus commented May 7, 2019

@JonasVautherin I've just checked and I see that gRPC-Swift 0.9.0 doesn't work with the XCode 10.1 (Swift 4.2) but the latest commit in master works.

@JonasVautherin
Copy link
Collaborator

Oh, good find!

Just to recap then: it broke, but...

  • We haven't changed the release of gRPC-Swift that we use
  • We are still building with Swift 4.2

What could have changed that would break the build? Could it be a change in RxSwift? Like instead of ~> 4.0 should we fix it to some version?

@byuarus
Copy link
Collaborator

byuarus commented May 7, 2019

Hi @JonasVautherin,

  • I think that the Carthage was broken for a while when you have changed the version of gRPC-Swift that you use. I think it was the only issue for the Carthage builds. Please check my PR Point to the working commit of gRPC-Swift to fix Cartgage builds #122 that should fix Carthage support for the SDK.
  • Yes, we're still using XCode 10.1 and Swift 4.2. We can't migrate our code to Swift 5 and XCode 10.2 yet as some of our 3rd party libraries haven't done the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants