update clippy linting job #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieleades
force-pushed
the
clippy-ci
branch
from
5f6272f
to
b63c786
Compare
patrickelectric
requested changes
Nov 30, 2022
I don't think this one's ready for the big time yet. See giraffate/clippy-action#23 |
danieleades
force-pushed
the
clippy-ci
branch
from
d599233
to
bedc3b3
Compare
danieleades
force-pushed
the
clippy-ci
branch
from
1592fd7
to
f3f3cf6
Compare
|
upstream github action has been fixed. Just waiting on a release, and then this will be ready for review |
|
i take it back. the action is still escalating clippy warnings to hard build failures, just in a different way... |
|
closing in favour of #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old action is unsupported. This one will add inline comments to PRs. pretty.
question - what feature set should be enabled when performing clippy linting?
i'd prefer for the clippy warnings not to be escalated to build failures, so I'll leave this as a draft until I have a resolution there - see giraffate/clippy-action#23