Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a list of the breaking changes in
ws@3
: https://github.com/websockets/ws/releases/tag/3.0.0.The most important is that the
http.IncomingMessage
object is no longer attached to theWebSocket
object and is instead passed as the second argument to the'connection'
event.It seems that websocket-stream does not rely on the removed
upgradeReq
property so this should be a safe and easy update.One thing to keep in mind is that
stream.socket.upgradeReq
is gone so this might be a breaking change.