Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to version 3.x #123

Merged
merged 3 commits into from
May 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"inherits": "^2.0.1",
"readable-stream": "^2.2.0",
"safe-buffer": "^5.0.1",
"ws": "^2.2.3",
"ws": "^3.0.0",
"xtend": "^4.0.0"
},
"devDependencies": {
Expand Down
7 changes: 4 additions & 3 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ We recommend disabling the [per message deflate
extension](https://tools.ietf.org/html/rfc7692) to achieve the best
throughput.

Default: `true`
Default: `true` on the client, `false` on the server.

Example:

Expand All @@ -65,7 +65,7 @@ var ws = websocket('ws://realtimecats.com', {
})
```

Beware that this is the only one option you cannot set on the client. You must set it on the server and this will be negotiated with the client.
Beware that this option is ignored by browser clients. To make sure that permessage-deflate is never used, disable it on the server.

##### Other options

Expand All @@ -79,7 +79,8 @@ Using the [`ws`](http://npmjs.org/ws) module you can make a websocket server and
var websocket = require('websocket-stream')
var wss = websocket.createServer({server: someHTTPServer}, handle)

function handle(stream) {
function handle(stream, request) {
// `request` is the upgrade request sent by the client.
fs.createReadStream('bigdata.json').pipe(stream)
}
```
Expand Down
4 changes: 2 additions & 2 deletions server.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ class Server extends WebSocketServer{
this.on('newListener', function(event) {
if (!proxied && event === 'stream') {
proxied = true
this.on('connection', function(conn) {
this.emit('stream', stream(conn, opts))
this.on('connection', function(conn, req) {
this.emit('stream', stream(conn, opts), req)
})
}
})
Expand Down
11 changes: 7 additions & 4 deletions test.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,10 @@ test('error on socket should forward it to pipe', function(t) {

test('stream end', function(t) {
t.plan(1)

var server = http.createServer()
websocket.createServer({ server: server }, handle)

function handle (stream) {
stream.pipe(concat(function (body) {
t.equal(body.toString(), 'pizza cats\n')
Expand All @@ -210,7 +210,7 @@ test('stream end', function(t) {
})

test('stream handlers should fire once per connection', function(t) {
t.plan(1)
t.plan(2)

var server = http.createServer()
var wss = websocket.createServer({ server: server }, function() {
Expand All @@ -220,7 +220,10 @@ test('stream handlers should fire once per connection', function(t) {
})

var m = 0
wss.on('stream', function() { m++ })
wss.on('stream', function(stream, request) {
t.ok(request instanceof http.IncomingMessage)
m++
})
server.listen(0, function() {
var w = websocket('ws://localhost:' + server.address().port)
w.end('pizza cats\n')
Expand Down