Select cant go back to best match #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @max-programming on Vercel. @max-programming first needs to authorize it. |
jolbol1
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I feel like this is the perfect solution! Thanks, James 😀 |
|
@all-contributors please add @jolbol1 for code and bug |
|
I've put up a pull request to add @jolbol1! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the sort dropdown could not go back to "best match" after you have selected something else.
Appears to be because best match uses
So it will just keep the queries that are currently there.
The fix is to delete these when generating the link component. Not sure if there is a better way to delete them in NextJs, without removing them all together (which would delete search ones too). Setting to null leaves these in the url
&s=&o=.Other option would be to make it so is sets the query params as "best" and sort as "desc".