Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fileName to gcloud command to allow usage of bucket name with path #60

Merged

Conversation

nicon89
Copy link

@nicon89 nicon89 commented May 10, 2023

With this code it's possible to specify gcloud bucket name with path, for example:

gcloud:
  bucket: test-bucket/backups/mongo

It's already working like this in s3.

@nicon89
Copy link
Author

nicon89 commented May 10, 2023

Btw, I found that in azure it creates a blob object in tmp/ directory:
image

Maybe a good alternative would be in fact adding new optional variable, like backupPath?

@nicon89
Copy link
Author

nicon89 commented May 10, 2023

@maxisam not sure why the checks have failed, looks like missing credentials?

@maxisam
Copy link
Owner

maxisam commented Jun 1, 2023

Sorry for that late reply. I am in vacation and out of states. And yes, it fails because of the missing credential. I need to make a better workflow

@maxisam maxisam merged commit a8e8771 into maxisam:main Jun 1, 2023
@maxisam
Copy link
Owner

maxisam commented Jun 1, 2023

@nicon89
Copy link
Author

nicon89 commented Jun 6, 2023

If it is same code, as the one pushed by me, then it must work - already using it on my side :)

@nicon89 nicon89 deleted the feature/allow_gcloud_bucket_with_path branch June 6, 2023 15:12
@maxisam
Copy link
Owner

maxisam commented Jun 8, 2023

awesome, I will cut a release then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants