Skip to content

Conversation

benvdh
Copy link

@benvdh benvdh commented Aug 12, 2016

Hi Max,

I added a note and example code to clarify how to deal with a single custom resource. You need to add a trailing comma there, else python will see it as a string and iterate over every character in the string. This turns every character into a resource path!

Added a note and example code to clarify how to deal with a single custom resource. You need to add a trailing comma there, else python will see it as a string and iterate over every character in the string, and turn every character into a resource path!
@coveralls
Copy link

coveralls commented Aug 12, 2016

Coverage Status

Changes Unknown when pulling 6cff178 on benvdh:patch-1 into * on maxtepkeev:master*.

@maxtepkeev maxtepkeev self-assigned this Aug 12, 2016
@maxtepkeev
Copy link
Owner

Hi @benvdh

I really appreciate your feedback and desire to make python-redmine better, but I don't think that this is something that should be added to documentation, because this has nothing to do with python-redmine, but with Python itself:

foo = ('foo.bar',)  # this is how you define a tuple in python
foo = ['foo.bar']   # you can also use a list, this way you don't need a trailing comma

What I'm trying to say is that python-redmine's documentation is not the right place to teach people how to write proper Python, there is a Python documentation for that, this is why I have to decline this pull request.

But once again, I really appreciate your feedback. Thanks.

@maxtepkeev maxtepkeev closed this Aug 12, 2016
@benvdh
Copy link
Author

benvdh commented Aug 12, 2016

Hi Max, Thank you for your feedback. I'll use the list way then. Thanks for the tip. I added some other points on the forums with regard to another method to query issues in more extensive way. I implemented it through the custom_resources feature now. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants