Update time_entry.rst to fix doc issue 165 #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the hour param should be float, I do not see any limitaion on that and Redmien takes floats for the time entries. Addusted also doctests to test and reflect changes
|
Thanks. Actually Redmine accepts both integer and float for hour parameter. Can you please adjust your pull request for this. After that I will be happy to merge it. |
loechel
changed the title
loechel
changed the title
|
adjusted to fix #165 |
maxtepkeev
requested changes
Mar 2, 2017
docs/resources/time_entry.rst
Outdated
|
|
||
| :param integer issue_id or project_id: (required). The issue id or project id to log time on. | ||
| :param integer hours: (required). The number of spent hours. | ||
| :param integer or float hours: (required). The number of spent hours. |
There was a problem hiding this comment.
Won't work this way, have a look at the definition of spent_on param below
docs/resources/time_entry.rst
Outdated
| :param integer resource_id: (required). Time entry id. | ||
| :param integer issue_id or project_id: (optional). The issue id or project id to log time on. | ||
| :param integer hours: (optional). The number of spent hours. | ||
| :param integer or float hours: (optional). The number of spent hours. |
There was a problem hiding this comment.
Won't work this way, have a look at the definition of spent_on param below
|
Changes Unknown when pulling 6775f81 on loechel:patch-1 into ** on maxtepkeev:master**. |
maxtepkeev
approved these changes
Mar 2, 2017
|
Yes, this is good, thank you. Will merge it a little bit later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update time_entry.rst to fix doc issue #165, the hour param should not be only integer it should be integer or float, I do not see any limitation on that and Redmine takes also floats for the time entries.
Addusted also doctests to test and reflect changes