Skip to content

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Oct 22, 2018

@calbrecht this should fix the issues you pointed out on #104

@xalopp xalopp requested a review from calbrecht October 22, 2018 20:10
@calbrecht
Copy link
Member

calbrecht commented Oct 22, 2018

LGTM 👍, thanks for keeping mo4 on a high standart.

-- edit
too fast -- Please change /** invalid doc block y is null by default / to /* invalid doc block after declaration */ to make it absolutely clear what is wrong with the comment.

@Ma27
Copy link
Contributor

Ma27 commented Oct 22, 2018

I guess two approvals for a documentation-only change should be sufficient.

@Ma27 Ma27 merged commit c94cf64 into mayflower:master Oct 22, 2018
@calbrecht
Copy link
Member

o.O i'm too slow fighting the mobile ;)

@Ma27
Copy link
Contributor

Ma27 commented Oct 22, 2018

dammit, according to the logs we missed each other by one minute^^

files patch

@calbrecht
Copy link
Member

Sorry for that -- well at least @xalopp will increase his visible contributions on the timeline that way ;)

@calbrecht
Copy link
Member

yeah i tried to do a review through this mobile app and it failed me several times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants