Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply microoptimization #137

Merged
merged 1 commit into from
Oct 4, 2019
Merged

apply microoptimization #137

merged 1 commit into from
Oct 4, 2019

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Oct 4, 2019

Type of PR

  • Bugfix
  • New Feature
  • Other (explain):

Apply microoptimizations

Breaking changes

  • Yes, this is a breaking change

Description

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #137   +/-   ##
=======================================
  Coverage       100%   100%           
  Complexity      133    133           
=======================================
  Files             6      6           
  Lines           556    556           
=======================================
  Hits            556    556
Impacted Files Coverage Δ Complexity Δ
...iffs/Formatting/AlphabeticalUseStatementsSniff.php 100% <100%> (ø) 35 <0> (ø) ⬇️
...4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php 100% <100%> (ø) 26 <0> (ø) ⬇️
...iffs/Formatting/UnnecessaryNamespaceUsageSniff.php 100% <100%> (ø) 27 <0> (ø) ⬇️
MO4/Sniffs/Commenting/PropertyCommentSniff.php 100% <100%> (ø) 22 <0> (ø) ⬇️
...iffs/Strings/VariableInDoubleQuotedStringSniff.php 100% <100%> (ø) 15 <0> (ø) ⬇️
MO4/Sniffs/Arrays/MultiLineArraySniff.php 100% <100%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb88aa0...eaa001c. Read the comment docs.

@mmoll mmoll merged commit f1ace38 into mayflower:master Oct 4, 2019
@mmoll
Copy link
Contributor

mmoll commented Oct 4, 2019

merged, merci @xalopp!

@xalopp xalopp deleted the micro_optimize branch October 4, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants