Pull in PSR12 #162
Pull in PSR12 #162
Conversation
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 133 133
===========================================
Files 6 6
Lines 553 553
===========================================
Hits 553 553 Continue to review full report at Codecov.
|
mmoll
force-pushed
the
psr12
branch
3 times, most recently
from
41ef5f3 to
573a145
Compare
| <rule ref="SlevomatCodingStandard.Namespaces.UseSpacing"> | ||
| <properties> | ||
| <property name="linesCountBeforeFirstUse" value="1"/> | ||
| <property name="linesCountBetweenUseTypes" value="0"/> |
There was a problem hiding this comment.
This didn't get support in GH-126, however, PSR-12 also wants to see it like this, so I'm trying again...
| <!-- exclude sniffs that are disabled on purpose by this standard --> | ||
| <exclude name="Generic.Files.LineLength.TooLong"/> | ||
| <!-- not compatible with other rules we have later on --> | ||
| <exclude name="PSR12.ControlStructures.ControlStructureSpacing"/> |
There was a problem hiding this comment.
Really puzzled by these multi line condition rules: https://www.php-fig.org/psr/psr-12/#51-if-elseif-else
|
I tried to pull in as much as possible from PSR12 while minimizing conflicts. In projects that extend MO4 and have own rules, there might be some new conflicts that need to get resolved by adjusting the other rules or excluding PSR12 stuff, but that's expected. |
|
Merci @mmoll |
No description provided.