Cover more Symfony styles with Slevomat sniffs #170
Conversation
| @@ -217,4 +217,15 @@ | |||
| <property name="ignoreUnusedValuesWhenOnlyKeysAreUsedInForeach" value="true"/> | |||
| </properties> | |||
| </rule> | |||
|
|
|||
| <!-- These should get handled by the upstream Symfony standard later --> | |||
| <rule ref="SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace"/> | |||
There was a problem hiding this comment.
"Do not use spaces around [ offset accessor and before ] offset accessor
|
|
||
| <!-- These should get handled by the upstream Symfony standard later --> | ||
| <rule ref="SlevomatCodingStandard.Arrays.SingleLineArrayWhitespace"/> | ||
| <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly"> |
There was a problem hiding this comment.
Add a use statement for every class that is not part of the global namespace;
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 133 133
===========================================
Files 6 6
Lines 511 514 +3
===========================================
+ Hits 511 514 +3
Continue to review full report at Codecov.
|
|
GH-167 should get fixed before this |
mmoll
force-pushed
the
moar_symfony
branch
2 times, most recently
from
01ebd37 to
a239dbf
Compare
Remaining problems seem to be fixed with Slevomat 7 :) |
Type of PR
Breaking changes
Requires new major version.