Refactor tests by introducting AbstractMo4SniffUnitTest #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xalopp
force-pushed
the
refactor_tests_duplicate_code
branch
2 times, most recently
from
3627761 to
78aebd4
Compare
xalopp
force-pushed
the
refactor_tests_duplicate_code
branch
from
78aebd4 to
1fea2e0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 133 133
===========================================
Files 6 6
Lines 509 509
===========================================
Hits 509 509 Continue to review full report at Codecov.
|
mmoll
approved these changes
Aug 29, 2021
|
merci @xalopp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Breaking changes
Description
This refactoring reduces the amount of duplicate code an makes the tests cleaner, because the test cases focus
on the tested file and the line that should contain warnings or errrors.