Skip to content

split up array alignment sniff #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Nov 28, 2017

split up array alignment sniff into ArrayDoubleArrowSniff and MutliLIneArraySniff
added fixer for space after array opening, fixes #30
added fixer for array closing must be on own line

@xalopp xalopp requested a review from mmoll November 28, 2017 13:40
@xalopp xalopp added this to the v2.0.0 milestone Nov 28, 2017
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #54 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
+ Coverage     95.99%   96.18%   +0.19%     
- Complexity      120      126       +6     
============================================
  Files             6        7       +1     
  Lines           624      656      +32     
============================================
+ Hits            599      631      +32     
  Misses           25       25
Impacted Files Coverage Δ Complexity Δ
...4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php 100% <ø> (ø) 17 <0> (?)
MO4/Sniffs/Arrays/MultiLineArraySniff.php 100% <100%> (ø) 8 <8> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2927c7a...9ab87f3. Read the comment docs.

@xalopp xalopp force-pushed the new_line_after_opening_multiline_array branch from 3f1d6cf to 9ab87f3 Compare November 28, 2017 15:26
@mmoll mmoll merged commit 98f658a into mayflower:master Nov 28, 2017
@mmoll
Copy link
Contributor

mmoll commented Nov 28, 2017

merged, merci @xalopp!

@xalopp xalopp deleted the new_line_after_opening_multiline_array branch November 29, 2017 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The opening parenthesis/bracket of a multi line array must be followed by a new line
2 participants