Skip to content

Conversation

xalopp
Copy link
Contributor

@xalopp xalopp commented Dec 5, 2017

No description provided.

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage     96.89%   96.89%           
  Complexity      124      124           
=========================================
  Files             6        6           
  Lines           547      547           
=========================================
  Hits            530      530           
  Misses           17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e785d98...7b7d368. Read the comment docs.

@calbrecht
Copy link
Member

👍

CONTRIBUTING.md Outdated
@@ -3,6 +3,7 @@
If you contribute code, please make sure it conforms to the
[PHPCS coding standard](https://github.com/squizlabs/PHP_CodeSniffer/blob/master/phpcs.xml.dist)
and that the unit tests still pass.
When ever possible, add auto fixer for coding standard violations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Whenever"

CONTRIBUTING.md Outdated
@@ -3,6 +3,7 @@
If you contribute code, please make sure it conforms to the
[PHPCS coding standard](https://github.com/squizlabs/PHP_CodeSniffer/blob/master/phpcs.xml.dist)
and that the unit tests still pass.
When ever possible, add auto fixer for coding standard violations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...add an auto fixer"

README.md Outdated
## License

This project is licensed under the MIT license.
See [LICENSE](LICENSE) file for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm-kay

README.md Outdated
</properties>
</rule>
```
* [PHP](http://php.net) 5.4 or any later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...version?
or "...or later"

@mmoll mmoll merged commit a6d3653 into mayflower:master Dec 6, 2017
@mmoll
Copy link
Contributor

mmoll commented Dec 6, 2017

merged, merci @xalopp!

@xalopp xalopp deleted the update_doc branch December 8, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants