Use Slevomat Coding Standard method typehinting #83
Conversation
composer.json
Outdated
| @@ -28,6 +28,7 @@ | |||
| "squizlabs/php_codesniffer": "^3.2.3", | |||
| "escapestudios/symfony2-coding-standard": "^3.0", | |||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.4.3", | |||
| "php": ">=5.6.0" | |||
| "php": ">=5.6.0", | |||
There was a problem hiding this comment.
As Slevomat requires PHP 7.1, we could also bump this here.
|
Using Slevomat means to drop PHP 5. Symfony 3.4 is is requires at least 5.5.9. So this PR would be a breaking change. Or shall we create a new branch to keep compat to 3.4 for 5.5.9? |
|
@xalopp Please see GH-84 for a separate PHP 7.1 change. I'd suggest to merge GH-85 first and then branch off 2.x. But to be honest, personally I don't see any relationship between our CS and Symfony's PHP requirements. Even now we do require 5.6, which is >5.5.9. Bringing in this new sniff here would require a major version bump anyway. |
xalopp
force-pushed
the
fix_81_php7_return_type
branch
2 times, most recently
from
1416813 to
d15bf7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
Coverage 98.46% 98.46%
Complexity 124 124
=========================================
Files 6 6
Lines 522 522
=========================================
Hits 514 514
Misses 8 8Continue to review full report at Codecov.
|
xalopp
force-pushed
the
fix_81_php7_return_type
branch
from
d15bf7f to
4947d2b
Compare
xalopp
changed the title
README.md
Outdated
| @@ -35,7 +35,10 @@ The MO4 Coding Standard is an extension of the [Symfony Coding Standard](http:// | |||
| * There must be at least one space around operators, and (except for aligning multiline statements) at most one, see the | |||
| [respective Squizlabs Sniff](https://github.com/squizlabs/PHP_CodeSniffer/wiki/Customisable-Sniff-Properties#squizwhitespaceoperatorspacing) | |||
| we imported with `ignoreNewlines = false` | |||
| * Single quotes must be used instead of double quoutes, where possible. | |||
| * Single quotes must be used instead of double quotes, where possible. | |||
| * all method requires a return type; use `void` if the method returns nothing. | |||
There was a problem hiding this comment.
And for consistency reasons with the bullet points above I'd vote for uppercase first :)
README.md
Outdated
| * Single quotes must be used instead of double quoutes, where possible. | ||
| * Single quotes must be used instead of double quotes, where possible. | ||
| * all method requires a return type; use `void` if the method returns nothing. | ||
| * all method parameters that defaults to null must be marked as nullable with the `?` symbol. |
There was a problem hiding this comment.
"that default" and maybe use backticks for the null
|
I ran this against a small modern codebase and the results are pretty great 👍 |
|
@xalopp could you please also add |
xalopp
force-pushed
the
fix_81_php7_return_type
branch
from
4947d2b to
d87604e
Compare
No description provided.