Deferred deletion check: support RHEL7.4+ kernels #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These kernels have the feature for deferred deletion built-in but disabled by default. A sysctl knob is available to turn it on. This patch checks if the knob is available but not enabled -- in this case case it enables it for the duration of the test and gives a user a recommendation on how to enable it permanently. BEFORE: ``` [root@kir-ce73-gd docker-devicemapper-setup]# ./deferred_deletion_check/standalone_deferred_deletion_check.sh Kernel version: 3.10.0-693.2.2.el7.x86_64 Deferred deletion is not supported ``` AFTER: ``` [root@kir-ce73-gd docker-devicemapper-setup]# ./deferred_deletion_check/standalone_deferred_deletion_check.sh Kernel version: 3.10.0-693.2.2.el7.x86_64 WARNING: it seems you are using RHEL/CentOS 7.4+ kernel but the fs.may_detach_mounts sysfs setting is disabled (set to 0). Setting fs.may_detach_mounts = 1 for the duration of the test. To enable this permanently, run the following: echo "fs.may_detach_mounts=1" | sudo tee -a /etc/sysctl.d/90-docker.conf sudo sysctl -f /etc/sysctl.d/90-docker.conf Deferred deletion is supported ``` [v2: drop use of trap as it's used elsewhere] Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
mbentley
approved these changes
Sep 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These kernels have the feature for deferred deletion built-in
but disabled by default. A sysctl knob is available to turn it on.
This patch checks if the knob is available but not enabled -- in
this case case it enables it for the duration of the test and gives
a user a recommendation on how to enable it permanently.
BEFORE
AFTER
[v2: drop use of trap as it's used elsewhere]
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com