use: Detect module path before sourcing #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #25. Now any modules containing errors will be identified as such, rather than being reported as unknown.
mbland
force-pushed
the
module-import
branch
from
bc16e46 to
92bc468
Compare
It's slightly wasteful to keep issuing `-f "$__go_module_file"` checks after finding a valid file path.
It could be that the module has syntax errors, or that it failed to define or import all its necessary functions and variables, or that it deliberately raised an error based on an error condition. It's better to state plainly that the import failed, and permit the user to ascertain the cause from the module's output, rather than making it sound like the module script is broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25. Now any modules containing errors will be identified as such, rather than being reported as unknown.
Also contains a minor fix to the
./go help modulestext.cc: @JohnOmernik