Fix Kyrgyzstan and Kazakhstan configs. #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyrgyzstan We have kg - local - not ky. Native - Кыргызча - it's like English. if you write Кыргыз тили - it's like English language regional - kgz - KG not ky- KG Kazakhstan They have kz - not kk Native - қазақ тілі - It's like English language. If you write Қазақ - it's like English name - Kazakhstan
|
Can you rebase with master? It will fix the conflicts, thanks! |
ashatrov
reviewed
May 1, 2017
| @@ -210,7 +210,7 @@ | |||
| //'az-Cyrl' => ['name' => 'Azerbaijani (Cyrillic)', 'script' => 'Cyrl', 'native' => 'Азәрбајҹан', 'regional' => 'uz_UZ'], | |||
| //'ab' => ['name' => 'Abkhazian', 'script' => 'Cyrl', 'native' => 'Аҧсуа', 'regional' => ''], | |||
| //'os' => ['name' => 'Ossetic', 'script' => 'Cyrl', 'native' => 'Ирон', 'regional' => 'os_RU'], | |||
| //'ky' => ['name' => 'Kyrgyz', 'script' => 'Cyrl', 'native' => 'Кыргыз', 'regional' => 'ky_KG'], | |||
| //'kg' => ['name' => 'Kyrgyzstan', 'script' => 'Cyrl', 'native' => 'Кыргызча', 'regional' => 'kgz_KG'], | |||
There was a problem hiding this comment.
-
I think here should be Language name, not Country Name.
Language name'name' => 'Kyrgyz', not'name' => 'Kyrgyzstan' -
Based on list of locales it should be
'regional' => 'kk_KZ'
bash$ locale -a
...
kk_KZ
kk_KZ.PT154
kk_KZ.UTF-8
...
- And key of this array element should be 'ky', because of key for the Kyrgyz Language in ISO 639-1 is
ky
There was a problem hiding this comment.
+1 @Rishats, can you reply to this?
There was a problem hiding this comment.
I don't know ! In our country all sites have xxx.kg and in KZ - xxx.kz
You may see there https://hoster.kg/
|
Closed because of inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kyrgyzstan
We have
kg - local - not ky.
Native - Кыргызча - it's like English. if you write Кыргыз тили - it's like English language
regional - kgz - KG not ky- KG
Kazakhstan
They have
kz - not kk
Native - қазақ тілі - It's like English language. If you write Қазақ - it's like English
name - Kazakhstan