Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable smoother Jupyter notebook experience #56

Closed
wants to merge 4 commits into from

Conversation

maxschulz-COL
Copy link
Collaborator

Description

  • discussion placeholder for duplicate ID "issue" in jupyter cell re-evaluations
  • all tests in the ipynb folder

Notes:

  • before the dashboard is built, it seems that there is no problem overwriting IDs OR (when having randomly generated ID's) adding new models to the managers
  • especially the second would eventually require us to have some form of garbage collection, although this seems not mandatory atm
  • HOWEVER: the re-building and adding to MM causes models (I think) to loose reference, and thus causing errors (see other app.ipynb)

Extra note:

  • why does the Vizro().run a actually modify state, nothing except self.dash.run should be executed (and of course freezing the managers...)

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@maxschulz-COL maxschulz-COL added the Type: Technical DR 💾 Issue/PR contains decision records (technical decisions made) label Sep 22, 2023
@maxschulz-COL maxschulz-COL changed the title Feature/enable smoother jupyter Enable smoother Jupyter notebook experience Sep 25, 2023
@maxschulz-COL
Copy link
Collaborator Author

This is now summarized here: #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Technical DR 💾 Issue/PR contains decision records (technical decisions made)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant