Skip to content

Conversation

harrysarson
Copy link

@harrysarson harrysarson commented Jan 2, 2018

This is a breaking change.

Applying either 18246bb or cc0cab6 by itself causes tests to fail.

Mergin this pr would require bumping npm to version 2.

@coveralls
Copy link

coveralls commented Jan 2, 2018

Coverage Status

Coverage increased (+0.006%) to 99.454% when pulling 0e2e2ef on HarrySarson:chai4 into 19548f7 on mcmath:master.

@harrysarson harrysarson changed the title Makes chai-iterator compatible with chai 4 Makes chai-iterator compatible with chai 4 #12 Jan 2, 2018
@harrysarson harrysarson changed the title Makes chai-iterator compatible with chai 4 #12 Makes chai-iterator compatible with chai 4; closes #12 Jan 12, 2018
@harrysarson
Copy link
Author

ping @mcmath

@TimothyGu
Copy link

@harrysarson Have you considered publishing your patched version of chai-iterator under a namespace on npm? It would help a lot of downstream users.

@harrysarson
Copy link
Author

@TimothyGu I have done :)

@TimothyGu
Copy link

@harrysarson Thanks!

@iamsimakov
Copy link

hi, guys! @harrysarson thnk you for package https://www.npmjs.com/package/@harrysarson/chai-iterator
but does anybody know will be this package updated here(https://www.npmjs.com/package/chai-iterator)?

@harrysarson
Copy link
Author

harrysarson commented Aug 9, 2018

Hi @iamsimakov, I have reached out to @mcmath by email as described in https://docs.npmjs.com/misc/disputes about three weeks ago.

I haven't yet heard anything back so I am hoping that the folk at npm might be able to transfer ownership. Once that happens I will release version 2 of chai-iterator with these updates.

@harrysarson harrysarson closed this Sep 4, 2018
@harrysarson harrysarson deleted the chai4 branch September 4, 2018 11:54
@harrysarson
Copy link
Author

@iamsimakov I have released version 3.0.0 of chai-iterator.

@iamsimakov
Copy link

iamsimakov commented Sep 4, 2018

@harrysarson Thanks!

@harrysarson
Copy link
Author

Does it work ok for you?

@iamsimakov
Copy link

@harrysarson I'm sorry but I can not check this version now, I will try it few days later, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants