-
Notifications
You must be signed in to change notification settings - Fork 6
Makes chai-iterator compatible with chai 4; closes #12 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ping @mcmath |
@harrysarson Have you considered publishing your patched version of chai-iterator under a namespace on npm? It would help a lot of downstream users. |
@TimothyGu I have done :) |
@harrysarson Thanks! |
hi, guys! @harrysarson thnk you for package https://www.npmjs.com/package/@harrysarson/chai-iterator |
Hi @iamsimakov, I have reached out to @mcmath by email as described in https://docs.npmjs.com/misc/disputes about three weeks ago. I haven't yet heard anything back so I am hoping that the folk at npm might be able to transfer ownership. Once that happens I will release version 2 of chai-iterator with these updates. |
@iamsimakov I have released version 3.0.0 of chai-iterator. |
@harrysarson Thanks! |
Does it work ok for you? |
@harrysarson I'm sorry but I can not check this version now, I will try it few days later, thanks |
This is a breaking change.
Applying either 18246bb or cc0cab6 by itself causes tests to fail.
Mergin this pr would require bumping npm to version 2.