Drop dependency on deprecated gulp-util #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Ci passed on Node 8, but it failed on Node 6 and Node 4, after I researched, this issue is related to typescript, right now, the code can just passed on TS 2.4.2, will break on the next versions, so I will just pin the TS to 2.4.2. Issues got from the Travis CI, which related to params.spec.ts Issues(partial)TSError: ⨯ Unable to compile TypeScript spec/params.spec.ts (19,36): Value of type '{ (value: T): T; (): undefined; }' has no properties in common with type '{ encoding?: null | undefined; thisArg?: any; }'. Did you mean to call it? (2560) at getOutput (/home/travis/build/mcmath/gulp-transform/node_modules/ts-node/src/index.ts:307:15) at /home/travis/build/mcmath/gulp-transform/node_modules/ts-node/src/index.ts:336:16 |
|
@mcmath ping? |
demurgos
approved these changes
Apr 6, 2018
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@types/chai": "^4.0.1", | ||
| "@types/chai-as-promised": "0.0.31", | ||
| "@types/lodash": "^4.14.71", | ||
| "@types/mocha": "^2.2.41", | ||
| "@types/node": "*", | ||
| "@types/plugin-error": "^0.1.0", |
There was a problem hiding this comment.
plugin-error bundles its own types: no need for the old @types/plugin-error package.
|
@demurgos Can we get this merged? |
|
I would like to, but I am not a maintainer of this repo. /cc @mcmath |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9