Support reporters #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
|
@mcollina nice project! |
|
Really nice! I'll take a look and see if I can integrate it. |
aduh95
reviewed
Jan 31, 2024
Comment on lines
+7
to
+13
| try { | ||
| res = fileURLToPath(new URL(file)) | ||
| } catch (err) { | ||
| if (err.code === 'ERR_INVALID_FILE_URL_PATH') { | ||
| res = fileURLToPath(new URL(file.replace('file:///', 'file://'))) | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't think your assesment is correct here, my understanding is that the URL that failed to be converted to path is file:///foo/test/add.test.ts, which indeed does not make sense on Windows. But that's a value constructed in your tests, not one generated by the test runner IIUC.
Suggested change
| try { | |
| res = fileURLToPath(new URL(file)) | |
| } catch (err) { | |
| if (err.code === 'ERR_INVALID_FILE_URL_PATH') { | |
| res = fileURLToPath(new URL(file.replace('file:///', 'file://'))) | |
| } | |
| } | |
| res = fileURLToPath(file) |
I'll try to send a PR.
There was a problem hiding this comment.
This was failing with a Windows path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.