Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/style #3

Merged
merged 16 commits into from
Jan 30, 2020
Merged

Feature/style #3

merged 16 commits into from
Jan 30, 2020

Conversation

mcrd25
Copy link
Owner

@mcrd25 mcrd25 commented Jan 30, 2020

Milestone 3

Implemented the following:

  • Used flex display mode for App, Display and ButtonPanel components
  • Styled Display component
  • Styled ButtonPanel component
  • Styled Button component
  • Added color and wide props for buttons. (Decided to make color prop boolean as the use of default prop did not make sense using if/else logic and my way of identifying the button to be orange required if logic. Might as well be a boolean since it's either one or the other.)

I look forward to the review

Copy link

@bellom bellom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mcrd25 👏

You have done wonderfully well, you passed all checklist for this milestone 👍

Congratulation 👍

Go ahead and merge to dev and don't forget to submit project completion form.
Good luck with your next milestone 🙂

Best,

Oluwaseun J. Bello
Slack Handle - @sean bellom

@mcrd25 mcrd25 merged commit 64f347f into development Jan 30, 2020
@mcrd25 mcrd25 deleted the feature/style branch January 30, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants