Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.Body.formData for Safari 14.1 #6620

Closed
1 task done
foolip opened this issue Aug 31, 2020 · 3 comments · Fixed by #10958
Closed
1 task done

Update api.Body.formData for Safari 14.1 #6620

foolip opened this issue Aug 31, 2020 · 3 comments · Fixed by #10958
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@foolip
Copy link
Collaborator

foolip commented Aug 31, 2020

A tracking bug for a few things that will need updating for future releases of Safari and Safari for iOS. This might be guesses based on what's currently in Safari Technology Preview, or recent commits to WebKit.

Safari 14.1:

@apple-web-evangelist FYI. If there's anything that could be done to make it easier to update Safari data for each release, that would be great :D

@queengooborg queengooborg added the bulk_update 📦 An update to a mass amount of data, or scripts/linters related to such changes label Aug 31, 2020
@foolip
Copy link
Collaborator Author

foolip commented Jan 14, 2021

This idea of a tracking issue didn't work out.

@foolip foolip closed this as completed Jan 14, 2021
@foolip foolip changed the title TODO for future Safari releases Update api.Body.formData for Safari 14.1 Jan 14, 2021
@foolip foolip added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API and removed bulk_update 📦 An update to a mass amount of data, or scripts/linters related to such changes labels Jan 14, 2021
@foolip
Copy link
Collaborator Author

foolip commented Jan 14, 2021

However, there was one TODO which is still in the future, so renaming and reopening to track just that one thing.

@foolip foolip reopened this Jan 14, 2021
foolip added a commit to foolip/browser-compat-data that referenced this issue Jun 11, 2021
Data from mdn-bcd-collector was used to confirm data for these versions:
- Chrome 42 (most entries)
- Chrome 43 (Response.body)
- Chrome 60 (formData attributes)
- Edge 14 (most entries)
- Edge 79 (formData attributes)
- Firefox 39 (most entries)
- Firefox 65 (Response.body)
- Safari 10.1 (most entries, including always-rejecting Response.formData)
- Safari 11.1 (Request.body + always-rejecting Request.formData)

The fixed formData attributes in Safari 14.1 / iOS 14.3 is based on:
mdn#6620

Anything else was mirrored, including all mobile browser data. IE was
not tested at all.

Notable differences to the original data:
- Request.body is not shipped in Chrome/Firefox:
  https://crbug.com/688906
  https://bugzil.la/1387483
- Response.body was shipped in Chrome 43:
  https://bugs.chromium.org/p/chromium/issues/detail?id=240603#c40
- Edge ≤18 versions all replaced
- A bunch of false values changed to real version

This also changes the experimental status to false, since this has all
been shipped basically everywhere now.

Closes mdn#6620.
Elchi3 pushed a commit that referenced this issue Jun 30, 2021
Data from mdn-bcd-collector was used to confirm data for these versions:
- Chrome 42 (most entries)
- Chrome 43 (Response.body)
- Chrome 60 (formData attributes)
- Edge 14 (most entries)
- Edge 79 (formData attributes)
- Firefox 39 (most entries)
- Firefox 65 (Response.body)
- Safari 10.1 (most entries, including always-rejecting Response.formData)
- Safari 11.1 (Request.body + always-rejecting Request.formData)

The fixed formData attributes in Safari 14.1 / iOS 14.3 is based on:
#6620

Anything else was mirrored, including all mobile browser data. IE was
not tested at all.

Notable differences to the original data:
- Request.body is not shipped in Chrome/Firefox:
  https://crbug.com/688906
  https://bugzil.la/1387483
- Response.body was shipped in Chrome 43:
  https://bugs.chromium.org/p/chromium/issues/detail?id=240603#c40
- Edge ≤18 versions all replaced
- A bunch of false values changed to real version

This also changes the experimental status to false, since this has all
been shipped basically everywhere now.

Closes #6620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@foolip @queengooborg and others