Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating optional_permissions based on feedback to #22034 #22097

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Jan 29, 2024

Summary

Various updates for feedback on Chrome optional permissions update #22034

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jan 29, 2024
@rebloor rebloor requested a review from Rob--W January 29, 2024 17:40
@rebloor rebloor self-assigned this Jan 29, 2024
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ with changes addressed.

webextensions/manifest/optional_permissions.json Outdated Show resolved Hide resolved
webextensions/manifest/optional_permissions.json Outdated Show resolved Hide resolved
@rebloor rebloor merged commit ac8aa81 into mdn:main Jan 30, 2024
6 checks passed
@rebloor rebloor deleted the chrome-optional_permissions-feedback-update branch January 30, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants