-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome optional permissions update #22034
Chrome optional permissions update #22034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately already merged, so please submit a PR with the requested fixups.
@@ -46,6 +46,26 @@ | |||
} | |||
} | |||
}, | |||
"alarm": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no alarm permission, it should be "alarms".
@@ -255,7 +275,7 @@ | |||
"description": "<code>debugger</code>", | |||
"support": { | |||
"chrome": { | |||
"version_added": true | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome does support the debugger permission. Set this back to true.
Alternatively, if the objective is to drop permissions that are not on MDN from BCD, drop the debugger
key.
@@ -355,12 +375,32 @@ | |||
} | |||
} | |||
}, | |||
"dns": { | |||
"__compat": { | |||
"description": "<code>dms</code>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "<code>dms</code>", | |
"description": "<code>dns</code>", |
"description": "<code>dms</code>", | ||
"support": { | ||
"chrome": { | ||
"version_added": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chrome does not support the dns API on release:
Note: This API is only available in Chrome Dev. There are no foreseeable plans to move this API from the dev channel into Chrome stable.
https://developer.chrome.com/docs/extensions/reference/api/dns
"firefox": { | ||
"version_added": false | ||
}, | ||
"firefox_android": "mirror", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"firefox": { | |
"version_added": false | |
}, | |
"firefox_android": "mirror", | |
"firefox": { | |
"version_added": true | |
}, | |
"firefox_android": { | |
"version_added": false | |
}, |
search is supported as an optional permission: https://searchfox.org/mozilla-central/rev/3c72de9280ec57dc55c24886c6334d9e340500e8/browser/components/extensions/schemas/search.json#10,14
Summary
This change aligns the compatibility information with the optional permission details provided by Chrome.
It only covers common permissions e.g., those shared between Firefox, Chrome, and Safari.
Related issues
Fixes #20858