This repository has been archived by the owner on Nov 10, 2017. It is now read-only.
bug 1128525 - Adjust browser names and slugs #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is going to get more complicated. Move the ugliness to mdn/data.py in preparation.
This code switches to the new browser names and slugs, but falls back to the old behaviour if the name of Firefox is "Firefox" rather than "Firefox for Desktop". This will allow us to push code, then make the data changes.
|
r+ |
jwhitlock
added a commit
that referenced
this pull request
Oct 6, 2015
bug 1128525 - Adjust browser names and slugs +r groovecoder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current browser names and slugs suggest that the desktop variants are the normal ones, and the mobile ones are the different ones. bug 1128525 changes this, so that "Firefox" (slug "firefox") becomes "Firefox for Desktop" (slug "firefox_desktop"). This is a three-part change: