-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added exprimental note about from keyword #33536
Conversation
Preview URLs Flaws (2)URL:
External URLs (1)URL:
(comment last updated: 2024-05-13 10:35:32) |
The `from` keyword is now parsed by firefox, behind a flag, this allows the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed. | ||
Currently this has no effect, but with out this the relative colors work can not proceed. (See [Firefox bug 1889133](https://bugzil.la/1889133) for more details.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this?
The `from` keyword is now parsed by firefox, behind a flag, this allows the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed. | |
Currently this has no effect, but with out this the relative colors work can not proceed. (See [Firefox bug 1889133](https://bugzil.la/1889133) for more details.) | |
The `from` keyword is now parsed as valid CSS syntax when the `layout.css.relative-color-syntax.enabled` preference is set to `true`. | |
This keyword currently has no effect but will not produce syntax errors when used in valid places in CSS color functions, allowing the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed. | |
See [Firefox bug 1889133](https://bugzil.la/1889133) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for you, but looking good! Leaving a +1 for when you have a chance to have a look 👀
Going to merge and open a small follow-up patch! Thanks a lot 🙏🏻 |
Description
Added experimental note for
from
keyword for relative colorsMotivation
Working on #33082
Related issues and pull requests
https://bugzilla.mozilla.org/show_bug.cgi?id=1889133