Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exprimental note about from keyword #33536

Merged
merged 2 commits into from
May 13, 2024

Conversation

dletorey
Copy link
Contributor

Description

Added experimental note for from keyword for relative colors

Motivation

Working on #33082

Related issues and pull requests

https://bugzilla.mozilla.org/show_bug.cgi?id=1889133

@dletorey dletorey requested a review from a team as a code owner May 10, 2024 16:01
@dletorey dletorey requested review from hamishwillee and removed request for a team May 10, 2024 16:01
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels May 10, 2024
Copy link
Contributor

github-actions bot commented May 10, 2024

Preview URLs

Flaws (2)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-05-13 10:35:32)

@bsmth bsmth self-requested a review May 13, 2024 13:45
Comment on lines +238 to +239
The `from` keyword is now parsed by firefox, behind a flag, this allows the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed.
Currently this has no effect, but with out this the relative colors work can not proceed. (See [Firefox bug 1889133](https://bugzil.la/1889133) for more details.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this?

Suggested change
The `from` keyword is now parsed by firefox, behind a flag, this allows the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed.
Currently this has no effect, but with out this the relative colors work can not proceed. (See [Firefox bug 1889133](https://bugzil.la/1889133) for more details.)
The `from` keyword is now parsed as valid CSS syntax when the `layout.css.relative-color-syntax.enabled` preference is set to `true`.
This keyword currently has no effect but will not produce syntax errors when used in valid places in CSS color functions, allowing the work for [relative colors](/en-US/docs/Web/CSS/CSS_colors/Relative_colors) to proceed.
See [Firefox bug 1889133](https://bugzil.la/1889133) for more details.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for you, but looking good! Leaving a +1 for when you have a chance to have a look 👀

@bsmth
Copy link
Member

bsmth commented May 13, 2024

Going to merge and open a small follow-up patch! Thanks a lot 🙏🏻

@bsmth bsmth merged commit b3bd7a4 into mdn:main May 13, 2024
8 checks passed
@dletorey dletorey deleted the 33082-from-keyword branch May 17, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants