Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor patch PR following up from Fx release docs #33582

Merged
merged 5 commits into from
May 13, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 13, 2024

Description

There's a few comments I had as suggestions to the following PRs:

Opening this here after the above PRs have been merged.

Thanks to @dletorey for the heavy lifting 🙏🏻

Motivation

Some minor additions before the release day tomorrow.

Related issues and pull requests

@bsmth bsmth requested review from a team as code owners May 13, 2024 14:37
@bsmth bsmth requested review from dipikabh and removed request for a team May 13, 2024 14:37
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Preview URLs

Flaws (8)

URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/basic-shape/shape

URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox
Flaw count: 3

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/basic-shape/shape

URL: /en-US/docs/Web/CSS/zoom
Title: zoom
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn//Getting_started_with_the_web/CSS_basics
External URLs (2)

URL: /en-US/docs/Mozilla/Firefox/Releases/126
Title: Firefox 126 for developers


URL: /en-US/docs/Mozilla/Firefox/Experimental_features
Title: Experimental features in Firefox

(comment last updated: 2024-05-13 16:00:08)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bsmth! I've added a few edit suggestions for you to review. Leaving my +1.

files/en-us/web/css/zoom/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/zoom/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/zoom/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/releases/126/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/experimental_features/index.md Outdated Show resolved Hide resolved
files/en-us/mozilla/firefox/experimental_features/index.md Outdated Show resolved Hide resolved
bsmth and others added 2 commits May 13, 2024 17:10
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@bsmth
Copy link
Member Author

bsmth commented May 13, 2024

Thanks, @dipikabh - merging shortly 🚢

@bsmth bsmth merged commit 1f71ae6 into mdn:main May 13, 2024
8 checks passed
@bsmth bsmth deleted the Fx126-minor-edits branch May 13, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants