-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache-control erroneous request #35199
cache-control erroneous request #35199
Conversation
Preview URLs External URLs (1)URL:
(comment last updated: 2024-07-29 02:20:21) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
For both requests and responses we know that negative/non-integer max-age
values are unspecified/undefined. For responses we know that caches are encouraged to treat the value as 0
, but we don't know what requests are expected to do.
I think we can assume that this is true for both requests and responses though, but as you have done here, we can't point to the freshness information in the spec as support for this assertion.
So IMO this is a good fix (with slightly tidied English).
But I think that the original information is also relevant for the responses - it is still (and more) true there. So perhaps we should also copy this removed text into the response directive section?
. I've slightly tidied the English.
The text is correct for responses, so how about we copy it up to the response senction?
That makes sense. Added the text to responses section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @gagan-bhullar-tech !
Description
Motivation
PR fixes #35169
Additional details
Related issues and pull requests