Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache-control erroneous request #35199

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

gagan-bhullar-tech
Copy link
Contributor

Description

Motivation

PR fixes #35169

Additional details

Related issues and pull requests

@gagan-bhullar-tech gagan-bhullar-tech requested a review from a team as a code owner July 28, 2024 16:34
@gagan-bhullar-tech gagan-bhullar-tech requested review from Elchi3 and removed request for a team July 28, 2024 16:34
@github-actions github-actions bot added Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed labels Jul 28, 2024
Copy link
Contributor

github-actions bot commented Jul 28, 2024

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/HTTP/Headers/Cache-Control
Title: Cache-Control

(comment last updated: 2024-07-29 02:20:21)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

For both requests and responses we know that negative/non-integer max-age values are unspecified/undefined. For responses we know that caches are encouraged to treat the value as 0, but we don't know what requests are expected to do.

I think we can assume that this is true for both requests and responses though, but as you have done here, we can't point to the freshness information in the spec as support for this assertion.

So IMO this is a good fix (with slightly tidied English).

But I think that the original information is also relevant for the responses - it is still (and more) true there. So perhaps we should also copy this removed text into the response directive section?

. I've slightly tidied the English.

The text is correct for responses, so how about we copy it up to the response senction?

@gagan-bhullar-tech
Copy link
Contributor Author

That makes sense. Added the text to responses section.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @gagan-bhullar-tech !

@hamishwillee hamishwillee merged commit caffa58 into mdn:main Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache-Control Erroneous Request Directive max-age HTTP specification citation
2 participants