-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing and re-opening a pull request causes double/triple commenting. #151
Comments
Thanks for the detailed STR! This might be related to #79. |
opening and creating a PR both initiate the same API Action. We need to be tracking comments to fix this properly. I assume fixing #79 should make this issue go away, even though they are technically different issues. Going to leave this issue open in-case the fix is not enough. |
@openjck and I thought a solution may be:
That file name, line number, and line contents combination seems to be the same keys that GitHub uses to decide whether to collapse comments in the PR interface. But we can tweak the hash components as needed. |
STR:
Expected results:
Only opening a PR should add a comment
Actual results:
Closing the PR created another batch of line-by-line comments
Example:
groovecoder/discord-test#1
The text was updated successfully, but these errors were encountered: