Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #159 #164

Closed
wants to merge 1 commit into from
Closed

Fix #159 #164

wants to merge 1 commit into from

Conversation

Faeranne
Copy link
Contributor

Using express.static should pass requests to /docs to the local /docs folder.

Using express.static should pass requests to `/docs` to the local `/docs` folder.
@openjck
Copy link
Contributor

openjck commented Dec 14, 2015

Whoa, awesome! I'll look at this soon.

@openjck openjck self-assigned this Dec 14, 2015
@openjck
Copy link
Contributor

openjck commented Dec 18, 2015

This hosts TESTING.md, but Firefox prompts me to download the file or choose an application to open it with. Can we render the Markdown like we do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure if that will scale now that we need to host multiple Markdown files. Make we can use the marked library together with Nunjucks to render the Markdown-powered pages?

@Faeranne
Copy link
Contributor Author

Sounds like an option. Gulp can be set up to scale for as many files as we
want, so long as we aren't trying to add new files on the live server.

On Fri, Dec 18, 2015, 16:20 John Karahalis notifications@github.com wrote:

This hosts TESTING.md, but Firefox prompts me to download the file or
choose an application to open it with. Can we render the Markdown like we
do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure if
that will scale now that we need to host multiple Markdown files. Make we
can use the marked library together with Nunjucks to render the
Markdown-powered pages?


Reply to this email directly or view it on GitHub
#164 (comment).


Q: Why is this email five sentences or less?
A: http://five.sentenc.es

@Faeranne
Copy link
Contributor Author

Also, gulp would be more efficient with more users.

On Fri, Dec 18, 2015, 16:49 Blixa Morgan blixa@projectmakeit.com wrote:

Sounds like an option. Gulp can be set up to scale for as many files as
we want, so long as we aren't trying to add new files on the live server.

On Fri, Dec 18, 2015, 16:20 John Karahalis notifications@github.com
wrote:

This hosts TESTING.md, but Firefox prompts me to download the file or
choose an application to open it with. Can we render the Markdown like we
do with README.md?

We currently use Gulp to convert the Markdown to HTML, but I'm not sure
if that will scale now that we need to host multiple Markdown files. Make
we can use the marked library together with Nunjucks to render the
Markdown-powered pages?


Reply to this email directly or view it on GitHub
#164 (comment).


Q: Why is this email five sentences or less?
A: http://five.sentenc.es


Q: Why is this email five sentences or less?
A: http://five.sentenc.es

@openjck
Copy link
Contributor

openjck commented Dec 18, 2015

Yeah, Gulp is an option too. Whatever makes it easiest to work with multiple Markdown files.

@groovecoder
Copy link
Owner

See #159 (comment) ... I think we should close this without fixing ...

@groovecoder
Copy link
Owner

Closing this without fixing. We shouldn't serve the docs/ files via the website. We should update the home page with a link to GitHub for docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants