Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include audio/video fallback downloads. #2254

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

dracos
Copy link
Contributor

@dracos dracos commented Aug 21, 2022

As per e.g. the MDN audio help, “it's a good practice to provide some
content (such as the direct download link) as a fallback for viewers”
so include this good practice in the examples.

Links with mdn/content#19790 to update other similar content on the page.

As per e.g. the MDN audio help, “it's a good practice to provide some
content (such as the direct download link) as a fallback for viewers”
so include this good practice in the examples.
@welcome
Copy link

welcome bot commented Aug 21, 2022

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Copy link
Member

@NiedziolkaMichal NiedziolkaMichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great. I have just fixed 2 extensions from webm to mp4. Thanks a lot!

@NiedziolkaMichal NiedziolkaMichal merged commit 9234b56 into mdn:main Sep 20, 2022
@welcome
Copy link

welcome bot commented Sep 20, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants