Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve existing example checkbox.html #2277

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

valentin-p
Copy link
Contributor

Improve an existing example.

I am fixing the inline html markup for "checked" in the checkbox example.

I noticed the issue in this site.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox

Before
image

After
image

Have a nice day.

I am fixing the inline html markup for "checked" in the checkbox example.

I noticed the issue in this site.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox
@welcome
Copy link

welcome bot commented Sep 22, 2022

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@NiedziolkaMichal NiedziolkaMichal merged commit 0404111 into mdn:main Sep 22, 2022
@welcome
Copy link

welcome bot commented Sep 22, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@NiedziolkaMichal
Copy link
Member

Thanks a lot, that's a good change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants