Bug 1148743 - Open jsfiddle and CodePen for Samples #3240
Conversation
|
Yep, you can see the updated template in the gist -https://gist.github.com/iakshay/18dba5dac3d6ce99967d |
|
OK, I've updated this so it works. \o/ Something to note: we're going to fight popup blockers, and of course, we can't prevent that. @hoosteeno @stephaniehobson Wanna do a style or usability check here? |
|
@hoosteeno : Also of note re: popup blockers, if the user chooses "allow popups", the window opens but the post data (the CSS, HTML, and JS) doesn't get delivered, so our functionality will appear broken, at least in Firefox. |
|
Review is going to be delayed until I have the new VM running, sorry! |
|
|
||
| function openJSFiddle(title, htmlCode, cssCode, jsCode) { | ||
| var $form = $('<form method="post" target="_blank" action="https://jsfiddle.net/api/mdn/" class="hidden">' | ||
| + '<input type="hidden" name="html" />' |
There was a problem hiding this comment.
JSHint suggests the "+" for each of these multi-line declarations should go on the preceding line.
|
I'm not able to get it to run locally. What am I missing:
The class |
Supercedes #3147
@iakshay I don't see where we use
.sample-code-frameor.sample-code-table-- is that something that needs to be added to the Embed template or...?