Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tapenade 3.16 to a specific build version, and update Ubuntu runners to U22.04 #58

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Aug 2, 2023

Purpose

Currently, we are using the latest Tapenade version when running the checks on Azure. However, this might not be the most stable approach, as they seem to be generating releases/updates directly from develop branch, setting it as the latest 3.16 to download. A floating version like this will fail the tests, as the header in the differentiated files will at minimum change. Furthermore, Tapenade has been silently failing, causing false positives (see recent build logs).

This PR fixes the 3.16 version to a specific build tapenade_3.16-v2-123-gcc03863c3. This version is chosen since more recent versions append *4 to an integer declaration in reverse mode codes. See discussion on this here mdolab/idwarp#82 (comment)

The build environment is also updated to U22.04 due to a GLIBC_2.34 error on U20.04. To keep consistency, the same is done for other build environments.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner August 2, 2023 17:06
@eirikurj eirikurj requested review from hajdik and bernardopacini and removed request for a team August 2, 2023 17:06
Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Nice catch on the GLIBC error. Maybe we should update all the vmImages to U22?

@eirikurj
Copy link
Contributor Author

eirikurj commented Aug 2, 2023

Yeah, we should do that. Will push an update shortly and update the PR description.

@eirikurj eirikurj changed the title Fix tapenade 3.16 to a specific build version Fix tapenade 3.16 to a specific build version, and update Ubuntu runners to U22.04 Aug 2, 2023
@sseraj sseraj merged commit 4491f48 into main Aug 2, 2023
@sseraj sseraj deleted the fixTapenade branch August 2, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants