Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeRefAxis is midly broken #69

Closed
bbrelje opened this issue Feb 28, 2021 · 1 comment · Fixed by #107
Closed

writeRefAxis is midly broken #69

bbrelje opened this issue Feb 28, 2021 · 1 comment · Fixed by #107
Assignees
@bbrelje
Labels
bug Something isn't working

Comments

@bbrelje
Copy link
Collaborator

bbrelje commented Feb 28, 2021

Description

DVGeometry.writeRefAxes appears to have broken midly due to a change in OrderedDict(). It should be reg tested but currently is not

Steps to reproduce issue

  1. Call writeRefAxes in the normal manner

Current behavior

Raises the following error:

Traceback (most recent call last):
  File "runFFDExample.py", line 50, in <module>
    DVGeo.writeRefAxes('local_refaxes.dat')
  File "/home/ben/packages/pygeo/pygeo/DVGeometry.py", line 2066, in writeRefAxes
    print(self.points.keys()[0])
TypeError: 'odict_keys' object is not subscriptable

Expected behavior

Should not do that
@bbrelje
Copy link
Collaborator Author

bbrelje commented Feb 28, 2021

Just needs to be cast to a list, I'll take care of it in my docs push

@bbrelje bbrelje self-assigned this Feb 28, 2021
bbrelje added a commit to bbrelje/pygeo-1 that referenced this issue Mar 2, 2021
@bbrelje
fixes writeRefAxes error closes mdolab#69
a0e3205
@ewu63 ewu63 added the bug Something isn't working label May 10, 2021
@marcomangano marcomangano mentioned this issue Nov 3, 2021
Merged
12 tasks
@sseraj sseraj linked a pull request Nov 3, 2021 that will close this issue
writeRefAxes fix for Python 3 #107
Merged
12 tasks
marcomangano added a commit that referenced this issue Aug 4, 2022
@bbrelje @anilyil
@ewu63 @hajdik @sseraj @marcomangano
New expanded feature docs (#71)
23150ad 
* move the examples folder

* fixes writeRefAxes error closes #69

* move dpw crm gif to doc/images folder

* move examples folder back to root

* move examples back to root

* add cylinder example to docs

* add c172 local global param tutorial examples

* add selective code embed feature to docs

* add getting started tutorial to docs

* improved index page

* FFD tutorials done

* ignore doc build files from git

* minor change to docs

* post-merge fixes

* Messed up merge commit

* flake8 fixes

* flake8 fixes

* removed hosted extension

* added embed_code from theme

* black format

* updated index

* converted some embed-code to literalinclude

* converted the rest of the code

* intersphinx updates

* rearranging docs structure

* unifying pointset spelling

* formatting stuff

* fitted FFD note

* marco comments

* moved content to new page so it is easier to find

* proofreading

* added figures for embedded FFD volume

* formatting

* marco comments

* more marco comments

* example script edits

* changed function references to docs links

* fixing docs errors

* redid cylinder figures

* random reformatting from when I was bored at home

* forgot to save DVGeoESP whoops

* Clarified `xFraction` docstrings and added `yFraction` and `zFraction`

* clarified xyzFraction in the docs - is it understandable?

* flake8/black fixes

* updated depracated functions

Co-authored-by: Anil Yildirim <anily@umich.edu>
Co-authored-by: Neil Wu <602725+nwu63@users.noreply.github.com>
Co-authored-by: Hannah Hajdik <hajdik@umich.edu>
Co-authored-by: sseraj <sseraj@umich.edu>
Co-authored-by: Sabet Seraj <48863473+sseraj@users.noreply.github.com>
Co-authored-by: Marco Mangano <36549388+marcomangano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbrelje bbrelje

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

writeRefAxes fix for Python 3 mdolab/pygeo
2 participants
@ewu63 @bbrelje