Skip to content

Conversation

ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Sep 9, 2020

Purpose

Black recently released a new (hopefully last) beta version after a year or so, which is why the tests failed on the master branch. Here I updated the code so that it conforms to black again. As far as I can tell, the main change relevant for us is the new capability to handle docstrings, which is what most of the diffs are about.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Formatting

Checklist

Put an x in the boxes that apply.

  • I have run flake8 and black to make sure the code adheres to PEP-8 and is consistently formatted
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner September 9, 2020 17:21
@ewu63 ewu63 requested review from marcomangano and sseraj September 9, 2020 17:21
Copy link
Collaborator

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the changes are very minor and the checks pass, so I believe everything is fine! Might be a good time to start re-formatting other repos?

@ewu63
Copy link
Collaborator Author

ewu63 commented Sep 9, 2020

Yeah, probably a good time if anyone has time. This shows the power of automatic tests, which was able to catch this when we probably would not.

If you format code locally you will have to update black using pip install black -U.

@sseraj sseraj merged commit 472e94d into master Sep 9, 2020
@sseraj sseraj deleted the black-format branch September 9, 2020 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants