Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in count-duplicates feature #20

Closed
edurand opened this issue Nov 26, 2015 · 1 comment
Closed

Bug in count-duplicates feature #20

edurand opened this issue Nov 26, 2015 · 1 comment

Comments

@edurand
Copy link

edurand commented Nov 26, 2015

Running fastqp input.bam -o output -d raises UnboundLocalError: local variable 'ScalableBloomFilter' referenced before assignment

The bug can be traced to cli.py lines 132-133 and 138-139. The order of two blocks need to be reversed (or better, the two blocks need to be merged since they are testing for the same thing), so that ScalableBloomFilter is imported before it's used.

@mdshw5
Copy link
Owner

mdshw5 commented Nov 30, 2015

Thanks, @edurand. This is kind of a silly error and I guess I should point out that the duplicate calculations are probably wildly underestimated if you're using the default sampling of 2M reads. I guess if you're evaluating all the reads in a file then this is a useful feature, so maybe I'll add a warning or mutually exclusive arguments that prevent misinterpretation of this value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants