[MCC-1080029] Fix Body Bug / Remove EOL Python 3.7 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejinotti-mdsol
changed the title
ejinotti-mdsol
requested review from
johnduhart,
ykitamura-mdsol and
lzanolcastanheira
lzanolcastanheira
approved these changes
Jun 24, 2023
| [tool.poetry] | ||
| name = "mauth-client" | ||
| version = "1.5.1" | ||
| version = "1.6.0" |
There was a problem hiding this comment.
Should it be 1.5.2 instead (patch fixing broken minor version 5)?
There was a problem hiding this comment.
went with 1.6.0 because i also decided to remove python 3.7 which is EOL tomorrow: https://endoflife.date/python
Comment on lines
+73
to
+76
| # seek() will not work because production Flask and gunicorn give | ||
| # objects without a seek() function and blow up... | ||
| # yet humorously Flask in our tests gives a normal BytesIO object | ||
| # that does have seek() |
| requests = "^2.23" | ||
| cachetools = "^5.3" | ||
| rsa = "^4.0" | ||
| importlib-metadata = {version = ">=3.6", python = "<3.8"} |
There was a problem hiding this comment.
can you remove this except block also?
mauth-client-python/mauth_client/__init__.py
Lines 4 to 6 in cc956ff
ykitamura-mdsol
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.