-
Notifications
You must be signed in to change notification settings - Fork 29
Fix for Directory Ordering compare function. #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sftse
reviewed
Jul 1, 2025
sftse
reviewed
Jul 1, 2025
sftse
reviewed
Jul 1, 2025
Thanks, that clears things up. |
Ah, that makes sense. Thanks for figuring this out. |
Co-authored-by: sftse <c@farsight.net>
sftse
approved these changes
Jul 2, 2025
Thanks, looks good to me; just need to make clippy happy. (Either by taking its suggestion, or by suppressing the warning for the sake of the TODO; either way seems fine to me.) |
sftse
reviewed
Jul 3, 2025
Co-authored-by: sftse <c@farsight.net>
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
This is caused by the way that Rust does case folding. Rust does full case folding where the MS-CFB spec states that simple case folding should be used.
Because of the full case folding:
ßQÑ52Ç4ÅÁÔÂFÛCWCÙÂNË5Q==
becomesSSQÑ52Ç4ÅÁÔÂFÛCWCÙÂNË5Q==
where theß
should remain unchanged when using simple case folding.This imports the icu_casemap crate that can do the simple case folding. I also made it so that string compares don't allocate new strings.