Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade micromark-util-events-to-acorn #383

Merged
merged 5 commits into from
Apr 21, 2022
Merged

fix: upgrade micromark-util-events-to-acorn #383

merged 5 commits into from
Apr 21, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 19, 2022

@JounQin JounQin added 🐛 type/bug This is a problem 📦 area/deps This affects dependencies 🌊 blocked/upstream This cannot progress before something external happens first labels Apr 19, 2022
@JounQin JounQin requested a review from wooorm April 19, 2022 16:45
@JounQin JounQin self-assigned this Apr 19, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

Codecov Report

Merging #383 (1748bf1) into master (c497839) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          18       18           
  Lines         214      214           
  Branches       40       42    +2     
=======================================
  Hits          212      212           
  Misses          1        1           
  Partials        1        1           
Impacted Files Coverage Δ
packages/eslint-plugin-mdx/src/configs/base.ts 100.00% <ø> (ø)
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/traverse.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c497839...1748bf1. Read the comment docs.

@JounQin
Copy link
Member Author

JounQin commented Apr 20, 2022

@wooorm Any time to review?

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Is that all that’s needed to update to MDX 2? 🤔

packages/eslint-mdx/src/traverse.ts Show resolved Hide resolved
@JounQin
Copy link
Member Author

JounQin commented Apr 20, 2022

This looks good to me! Is that all that’s needed to update to MDX 2? 🤔

#384

There is another known issue for now.

@JounQin
Copy link
Member Author

JounQin commented Apr 20, 2022

@wooorm That issue doesn't block this PR, I think it's ready for a new next release?

@wooorm
Copy link
Member

wooorm commented Apr 21, 2022

sure!

@JounQin JounQin merged commit b5e8987 into master Apr 21, 2022
@JounQin JounQin deleted the fix/comments branch April 21, 2022 08:52
@wooorm
Copy link
Member

wooorm commented Apr 21, 2022

P.S. can you update deps (at least gajus/eslint-plugin-jsdoc#880 (comment)) so everything builds on Node.js 18?

@wooorm
Copy link
Member

wooorm commented Apr 21, 2022

Released 2.0.0-next.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 🌊 blocked/upstream This cannot progress before something external happens first 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

[v2] incorrect comment loc info
3 participants