Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined place in vFile message causes TypeError #521

Merged
merged 2 commits into from
Jan 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/new-brooms-visit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"eslint-plugin-mdx": patch
---

fix: `undefined` `place` in vFile message causes TypeError

Many `remark-lint` errors do not set a place variable in the vFile
message. This code should accept `undefined` for this field.

fixes #520
2 changes: 1 addition & 1 deletion packages/eslint-plugin-mdx/src/rules/remark.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const remark: Rule.RuleModule = {
// related to https://github.com/eslint/eslint/issues/14198
message: JSON.stringify(message),
loc:
/* istanbul ignore next */ 'start' in place
/* istanbul ignore next */ place && 'start' in place
JounQin marked this conversation as resolved.
Show resolved Hide resolved
? {
...point,
start: { ...place.start, column: place.start.column - 1 },
Expand Down