Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document LSP tracing configuration options #338

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

remcohaszing
Copy link
Member

This is provided by vscode-languageserver by default. This change just documents the configuration options and enables logging when using the fixtures workspace.

This is provided by `vscode-languageserver` by default. This change just
documents the configuration options and enables logging when using the
fixtures workspace.
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🗄 area/interface This affects the public interface 👶 semver/patch This is a backwards-compatible fix 🤞 phase/open Post is being triaged manually labels Aug 17, 2023
@remcohaszing remcohaszing requested a review from a team August 17, 2023 18:57
@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

🦋 Changeset detected

Latest commit: 206fbe1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-mdx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wooorm
Copy link
Member

wooorm commented Aug 17, 2023

Sounds good!

BTW, what's the plan/timeline for dropping the "experimental" status of the api?

@remcohaszing
Copy link
Member Author

BTW, what's the plan/timeline for dropping the "experimental" status of the api?

The next release is going to be basically a rewrite to use Volar. This is almost ready, I’m mainly still tweaking tests and discovering small quirks. I think it’s a good idea to replace the opt-in option mdx.experimentalLanguageServer with the opt-out option mdx.languageServer.enable or something like that.

@remcohaszing remcohaszing merged commit c2c67b8 into main Aug 17, 2023
2 checks passed
@remcohaszing remcohaszing deleted the document-lsp-tracing branch August 17, 2023 19:38
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
@remcohaszing
Copy link
Member Author

Released in vscode-mdx@1.5.0 🎉

@wooorm wooorm added the 💪 phase/solved Post is done label Nov 9, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

3 participants